Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow to use secret for s3 auth #100

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

feat: allow to use secret for s3 auth #100

wants to merge 17 commits into from

Conversation

VeselinUzunov
Copy link

@VeselinUzunov VeselinUzunov commented Oct 6, 2022 •
edited
Loading

Allow to use external secret for aws s3 Auth with AWS_AUTH_KEY and AWS_AUTH_SECRET properties

VeselinUzunov and others added 17 commits October 3, 2022 10:54
@tranchitella tranchitella self-requested a review November 29, 2022 08:57
oldgiova
oldgiova requested changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@oldgiova oldgiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, but for the sake of the documentation, can you also please update the README.md doc and describing the new AWS_SECRET_NAME value?

Thanks!

@oldgiova
Copy link
Contributor

It looks good, but for the sake of the documentation, can you also please update the README.md doc and describing the new AWS_SECRET_NAME value?

Thanks!

Hello @VeselinUzunov , thanks for your contribution! Just a minor documentation change.
Moreover, could you please squash your commits into one and sign it off?
Please refer to our contribution guide

@tranchitella tranchitella removed their request for review May 20, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oldgiova oldgiova oldgiova requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VeselinUzunov @oldgiova